Kdenlive   bug tracker Home page

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002016KdenliveEffectspublic2011-02-13 18:332011-04-27 23:41
Reporteryellow 
Assigned Toj-b-m 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusassignedResolutionopen 
Platform64bit Maverick MeerkatOSSunabs svn PPAOS Version
Product Version 
Target VersionFixed in Version 
Summary0002016: Pan & Zoom doesn't appear to work correctly.
DescriptionI'm trying to use the Pan & Zoom effect to make a 720P keyframed crop over a 1080P source video. No zoom required just panning a 720P crop area over a 1080P frame and keyframing the positions of the 720P crop.

I start with a 720P project, import 1080P source, apply Pan & Zoom and I get a 1080P yellow & red frame and a scaled down 1920x1080 frame to 1280x720 and it's positioned in the top left corner of the yellow 1920x1080 frame.

If I try to correct the frame size in the overides I end up with a 150% resize, so my 1920x1080 source frame gets automatically reduced in size to 1280x720 and then zoomed up by 150% to get it back to it's original size and I then still can't pan over the frame.

Additional InformationIt's totally crazy and not too much to ask to simply lay a 720P cropping frame over the larger 1920x1080 source frame, keyframe the crop and export a 720P movie surely.

Sorry I just don't understand the need to automatically resize all the time, same issue with Crop effect in another bug report.
TagsNo tags attached.
Build/Install Method3rd party package
Attached Filespng file icon PZEnd78.png [^] (79,391 bytes) 2011-02-14 22:28


png file icon PZEnd79.png [^] (61,110 bytes) 2011-02-14 22:29


png file icon pan zoom bug1.png [^] (87,306 bytes) 2011-03-01 09:13


png file icon pan zoom bug2.png [^] (86,627 bytes) 2011-03-01 09:13

- Relationships

-  Notes
(0006413)
j-b-m (administrator)
2011-02-14 01:42

I just fixed a few issues related to the "size" parameter used in the "Pan & Zoom" effect. Currently, the effect (and same is true of the composite transition and a few others) scales the picture to fit the project's frame size by default.

In the "Options" button of the effect, you now have the choice to "adjust to original size" which will restore the original clip size (in your case, 150% is correct since it shows percentage relative to the project's frame size).

However, I agree that by default, keeping the original size is probably better than scaling. Will see if I can fix that.

What is exactly the problem with panning? Seems to work here.
(0006416)
jjfro (reporter)
2011-02-14 22:45

Can I chime in here an say that I think the new Pan & Zoom effect is broken? I haven't encountered the same issue as Yellow has but I've got another one that is related to the newly designed effect. After I got the update to the latest svn (5392), I loaded an existing project to make sure things still worked as expected. I noticed the new Pan & Zoom effect layout on my .jpg clips that used that effect. I also noticed that none of the values in the fields were correct. Furthermore, all the keyframes except for the initial one were gone! Oddly enough, the clips still played correctly but if I tried to make any changes, things got seriously out of whack.

I've attached two screenshots of the way the effect stack looks on the same clip at the end of its duration; one from 0.7.8 and one from 0.7.9-5392.

Also, I don't understand the reason for putting some of the options under an "Options" button. It doesn't really save any screen space and just forces one to use an extra mouse click to get to controls that used to be readily available on the main effect screen.

I liked the previous Pan & Zoom effect just the way it was. :-(
(0006417)
j-b-m (administrator)
2011-02-14 23:36

Hmm, loosing keyframes is a serious problem. Could you attach the .kdenlive project file here or mail it to me (jb at kdenlive org).

The new design does save space... I was not sure if the "Align" buttons were used a lot, that's why I put them in the "Options menu". The advantage if this menu is that we can later add more options (like "fit to width", ...).

I will see if I can find a better layout and maybe put the "Align" buttons back if several users think it was better.
(0006418)
jjfro (reporter)
2011-02-14 23:45

Thanks for the quick response, j-b-m. I have e-mailed you the project file.

I guess the way I have my views configured, the Options button does not save me any space, but I can see that might not be true for everyone. However, I do use the Align buttons and the Resize field frequently when I'm doing my slideshows because I make heavy use of the Ken Burns effect.
(0006419)
yellow (reporter)
2011-02-15 06:55

jbm the problem with pan was that it just cuts off the image frame when moving the yellow frame about but maybe the fixes youve done will solve that

with regard to scaling by default and then rescaling back to original size ie 150% in my case is a little concerning if the scaling operation is actually being done twice even with decent interpolation like bicubic scaling down will damage the frame and then scaling what is left backup damages again certainly from the preview I see doing 150% the frame appears more pixelated

hope you can remove the auto scaling
(0006420)
j-b-m (administrator)
2011-02-15 10:18

@jjfro:
The problem you encountered (lost keyframes) does not exist anymore in current svn. I could reproduce with svn rev. 5392, but is was fixed since, so you just got the source at a bad time. Update when you can & the problem will go away.

@yellow:
The yellow frame shows the resized frame, and the red one shows the "monitor" frame. Currently, the way it is implemented, we cannot show the whole resized frame, but only the part that overlaps the red one.

About the scaling issue, I made some tests and it seems to work correctly for me.
I took a 1920x1080 png file in a 176x144 profile.

Applying a Pan and Zoom effect to restore original size (about 1000%), the image appears perfect BUT only if my project profile uses a Pixel aspect ratio of 1:1. If the Pixel aspect ratio is different, some scaling will occur, but I think that is correct.

So maybe the problem you are seeing is due to Pixel aspect ratio issues between source clip and project profile...
(0006421)
ttill (developer)
2011-02-15 17:02

The lost keyframes issue was fixed in r5399.
(0006426)
yellow (reporter)
2011-02-16 22:04

Ok I've found the bug after Dan kindly did a screencast of how Pan & Zoom should work. Here's how to replicate:

Set your default project as 1920x1080 25P.
Close kdenlive.
Reopen kdenlive gives a 1920x1080 project.
Do new project and choose 720 25P.
Add 1920x1080 clip to timeline and apply Pan & Zoom effect.
Notice the starting x y size is 1920 x 1080 not 1280 x 720 as it should be.
Then notice how the Pan & Zoom effect behaves totally wrong. :-)

Can you replicate, probably work for any differing project formats I guess.
(0006442)
j-b-m (administrator)
2011-02-17 23:57

Can you please make sure to update to svn rev 5404 at least, because there previously was a bug that caused new projects to keep some properties of the default project.

With current svn, I cannot reproduce your problem. The only problems I found is when adding clips with a different pixel aspect ratio than current project, it can cause some strange effects (clip not filling the yellow rect) but I think your problem is different.
(0006487)
insaner (reporter)
2011-02-24 15:48

trying to test this on svn (since pan and zoom in 0.7.8 is broken), but i cant compile

/home/insaner/kdenlive/build/svn/kdenlive/src/renderer.cpp: In member function ‘void Render::buildConsumer(QString)’:
/home/insaner/kdenlive/build/svn/kdenlive/src/renderer.cpp:186: error: ‘struct mlt_profile_s’ has no member named ‘is_explicit’
make[2]: *** [src/cmake_bindir/CMakeFiles/kdenlive.dir/renderer.o] Error 1
make[1]: *** [src/cmake_bindir/CMakeFiles/kdenlive.dir/all] Error 2
make: *** [all] Error 2

should i just wait a couple hours and try to get it from svn again? or file this as an issue?
(0006488)
j-b-m (administrator)
2011-02-24 17:33

@insaner:
You need latest MLT from git to use Kdenlive from svn.
(0006505)
insaner (reporter)
2011-03-01 08:03

ok, im not sure what yellow means by "totally wrong" but for me this means that the keyframes no longer exist, and that i cannot add new keyframes. im on 5463 i think.

 also, it would be good to have pan and zoom have the option to use the old red box in the properties, as this was super practical (ie, allow for the new way and the old way to be used.. let the user decide which one he wants) i can open a new issue for this
(0006518)
ddennedy (developer)
2011-03-03 06:00

re: old red box
"On-monitor effects" in Settings, Misc
(0006526)
insaner (reporter)
2011-03-04 00:30

ah awesome, thanks ddennedy. i still dont know how to fix my keyframes problem, though.

by the way, the gui seems to be getting better and cleaner every day!
(0006527)
ddennedy (developer)
2011-03-04 01:00

re: scaling by default and then rescaling

When you use Pan and Zoom it bypasses the auto-scaler that scales inputs to the project resolution. That was a fundamental part of fulfilling the high quality Ken Burns photo effect use case. As further evidence, many very high res photos with high frequency image detail shows shimmer artifacts when using Pan and Zoom. Hence the need to often insert something like a blur filter in front of Pan and Zoom to act as a low pass filter on very high res photos.
(0006528)
insaner (reporter)
2011-03-04 12:36

ok, further testing reveals what my keyframe problem might be about. it seems that its not that i cant add keyframes, its that the "last" keyframe cant be added. so, with my above examples, the clip lasted 2-3 frames, so the last keyframe cannot be added (which was possible with 0.7.7.1) which means that in essence, i cannot have keyframes for these clips (of which i have many many in my project) however, if i extend the clips to be a few more frames, then adding keyframes is possible. hope that helps!
(0006675)
ttill (developer)
2011-04-27 23:41

I changed some things regarding keyframe handling in Kdenlive in the mean time.
Can you still reproduce with latest SVN/0.8?

- Issue History
Date Modified Username Field Change
2011-02-13 18:33 yellow New Issue
2011-02-14 01:42 j-b-m Note Added: 0006413
2011-02-14 01:42 j-b-m Assigned To => j-b-m
2011-02-14 01:42 j-b-m Status new => feedback
2011-02-14 22:28 jjfro File Added: PZEnd78.png
2011-02-14 22:29 jjfro File Added: PZEnd79.png
2011-02-14 22:45 jjfro Note Added: 0006416
2011-02-14 23:36 j-b-m Note Added: 0006417
2011-02-14 23:45 jjfro Note Added: 0006418
2011-02-15 06:55 yellow Note Added: 0006419
2011-02-15 06:55 yellow Status feedback => assigned
2011-02-15 10:18 j-b-m Note Added: 0006420
2011-02-15 17:02 ttill Note Added: 0006421
2011-02-16 22:04 yellow Note Added: 0006426
2011-02-17 23:57 j-b-m Note Added: 0006442
2011-02-24 15:48 insaner Note Added: 0006487
2011-02-24 17:33 j-b-m Note Added: 0006488
2011-02-26 07:05 insaner Note Added: 0006500
2011-02-28 14:41 insaner Note Deleted: 0006500
2011-03-01 08:03 insaner Note Added: 0006505
2011-03-01 09:13 insaner File Added: pan zoom bug1.png
2011-03-01 09:13 insaner File Added: pan zoom bug2.png
2011-03-03 06:00 ddennedy Note Added: 0006518
2011-03-04 00:30 insaner Note Added: 0006526
2011-03-04 01:00 ddennedy Note Added: 0006527
2011-03-04 12:36 insaner Note Added: 0006528
2011-04-27 23:41 ttill Note Added: 0006675


Copyright © 2000 - 2014 MantisBT Team
Powered by Mantis Bugtracker