Kdenlive   bug tracker Home page

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002896KdenliveUser Interfacepublic2012-12-26 00:022012-12-26 13:59
Reporterlxvidcut 
Assigned Toj-b-m 
PrioritynormalSeverityminorReproducibilityalways
StatusassignedResolutionopen 
PlatformIntel 64BitOSOpenSUSEOS Version12.2
Product VersionRecent git 
Target VersionFixed in Version 
Summary0002896: Several length and duration issues
DescriptionSince a long time i notice several issues regarding wrong length and duration values by 1 frame.
Two examples:
I've title clips in the project tree with exact 8:00 s length. When I move it to the timeline the length on it is now 8:01 s (+1 frame).

I've a lot of clips in my timeline. All clips are overlapping by 5 frames with a standard dissolve transition. One of my last actions to make the movie ready is to add audio fade in and out effects of 5 frames length to each clip. I adjust these both effects on the first clip and then I copy and paste the effects to all other clips in the timeline. But the last pasted effect is now 4 frames long on all clips where I have pasted.

Best regards
Christian
TagsNo tags attached.
Build/Install MethodManual build from Git
Attached Files

- Relationships

-  Notes
(0008882)
j-b-m (administrator)
2012-12-26 00:47

Thanks for reporting these problems. I will fix them in the next hours.
(0008884)
j-b-m (administrator)
2012-12-26 01:07

Both issues should now be fixed, please report any other duration problems since these are usually annoying for users and easy to fix.
(0008886)
lxvidcut (reporter)
2012-12-26 01:35

Copy and Paste Effects is now fine!

Now all my saved titles are 8s:01 frames long. I think this is due to creating the titles with the buggy version.
Please confirm that these values are been interpreted as you have designed:
out="0" > 0s 1f title length
out="199" > 8s 0f title length
So I have to sed all my saved title files by -1 ? right?

But now adding titles from the tree to the timeline results in correct length!
Thanks!
Christian
(0008887)
j-b-m (administrator)
2012-12-26 01:38

Oh crap, I had not thought about previously saved title files. Wait a minute, I will make a change that preserves compatibility with previous files, no need to edit your files, just wait a few minutes...
(0008888)
lxvidcut (reporter)
2012-12-26 01:49
edited on: 2012-12-26 01:50

ok. a "new" issue found!
I have opened a old project from last week. in the tree the length is now 8:01. If a add the title to the timeline the length is 8:00!
When i add a new title or edit an existing then all seems to be ok.

I am not sure where you are fixing, but please ensure that kdenlive is working as designed and consistent.

So what stands e.g. out="1" in all xml files (project file, title file) for?

(0008889)
lxvidcut (reporter)
2012-12-26 02:14

For my understanding out="200" should be interpreted as 8s:0f. 8*25fps=200.
So out="0" will produce an length of 0s:0f, but I'm not sure if this is an valid value?
But I will not start a principle discussion, how kdenlive interprets these integer values, but the behavior should be identically on all functions. I mean the principle decision to start counting including zero or not. Changing this behavior will produce immense code changes on several functions ( add or remove -1 +1 corrections). I mean there are many time related variables like start, end and so on...
I will go to bed now... I'll continue tomorrow.
(0008890)
j-b-m (administrator)
2012-12-26 02:17

Ok, so after thinking a bit about it, yes the title clips saved with previous versions of Kdenlive will now show a duration of 1 frame more. (In fact these clips always had 1 extra frame in duration but Kdenlive did not show it in the title widget).

I will not change it because if these clips were used in older projects, changing their duration might corrupt the project.

So as you said in your last comment, if you have created title files and want them to have the correct duration, you will need to edit them manually and substract 1 to the "out" value, with for example 199 for 8 seconds in PAL format.

But beware that if you used those title files in previous projects, that might cause problems because their length has changed. So maybe it's better to make copies...
(0008891)
j-b-m (administrator)
2012-12-26 02:22

Yes, I agree that we should keep it consistent. But for now the bug is solved in the way that the dialog now shows the real duration.

I agree that the name we put on it in the .kdenlivetitle file format should be more consistent with what MLT uses, but anyways the titles in Kdenlive need a lot more work, so that naming issue is not an top priority.
(0008894)
j-b-m (administrator)
2012-12-26 09:22

Ok, so after a few hours of sleep I finally did something worth. I checked how the previous stable Kdenlive version behaved, and there, title duration were correct in Kdenlive. So the 1 frame offset in duration in clip properties was a recent regression.

However, in last stable version, the "out" property in .kdenlivetitle file is not the out in the way MLT handles it. So for better readability I now introduced a "duration" attribute in title files and will slowly deprecate the confusing "out" property.

Now, title files with "out=125" will have a 1 second duration, "out=1" means 1 frame length
(0008897)
lxvidcut (reporter)
2012-12-26 10:07

This sounds good and logically to me. Let me test and I will give you a feed back until tonight.

Hope that the interpretation of the values is kdenlive wide identically. Otherwise it decreases the comprehensibility of your code when e.g. a clip is interpreted different to a transition. I can remember on older kdenlive releases where a lot of such length issues were present. Fortunately this is history.

Is the refactoring project also observing such issues?
(0008901)
lxvidcut (reporter)
2012-12-26 13:59
edited on: 2012-12-26 14:07

Ok, now all seems to be ok in the UI with titles and new project files.

When I open a project file from day before yesterday in the UI all is ok. When saving this old project to a new one (with recent kdenlive version) or when I generate a rendering script with mlt file the following result can be observed in the project/mlt file:
 <producer in="0" out="200" id="124">
  <property name="mlt_type">producer</property>
  <property name="length">201</property>
  <property name="eof">pause</property>
  <property name="resource"/>
  <property name="progressive">1</property>
  <property name="mlt_service">kdenlivetitle</property>
  <property name="xmldata"><kdenlivetitle width="1920" duration="200" height="1080" LC_NUMERIC="en_US.UTF-8">

Please notice the length of 201 and the duration of 200 in the property xmldata. This also happens when I edit or reload (via file) the title in kdenlive. In the UI all is displayed correct = 8s0f duration.
So MLT will process 201 frames.

In a new project the same procedure produces correct code:
 <producer in="0" out="199" id="3">
  <property name="mlt_type">producer</property>
  <property name="length">200</property>
  <property name="eof">pause</property>
  <property name="resource"/>
  <property name="progressive">1</property>
  <property name="mlt_service">kdenlivetitle</property>
  <property name="xmldata"><kdenlivetitle width="1920" duration="200" height="1080" LC_NUMERIC="en_US.UTF-8">

But why? My assumption was that kdenlive is saving now all correct. Especially because all is been displayed correct in the UI on all places (tree, timeline) and there is no difference to a new project noticeable?


- Issue History
Date Modified Username Field Change
2012-12-26 00:02 lxvidcut New Issue
2012-12-26 00:47 j-b-m Note Added: 0008882
2012-12-26 00:47 j-b-m Assigned To => j-b-m
2012-12-26 00:47 j-b-m Status new => acknowledged
2012-12-26 01:07 j-b-m Note Added: 0008884
2012-12-26 01:07 j-b-m Status acknowledged => feedback
2012-12-26 01:35 lxvidcut Note Added: 0008886
2012-12-26 01:35 lxvidcut Status feedback => assigned
2012-12-26 01:38 j-b-m Note Added: 0008887
2012-12-26 01:49 lxvidcut Note Added: 0008888
2012-12-26 01:50 lxvidcut Note Edited: 0008888 View Revisions
2012-12-26 02:14 lxvidcut Note Added: 0008889
2012-12-26 02:17 j-b-m Note Added: 0008890
2012-12-26 02:22 j-b-m Note Added: 0008891
2012-12-26 09:22 j-b-m Note Added: 0008894
2012-12-26 10:07 lxvidcut Note Added: 0008897
2012-12-26 13:59 lxvidcut Note Added: 0008901
2012-12-26 14:07 lxvidcut Note Edited: 0008901 View Revisions


Copyright © 2000 - 2014 MantisBT Team
Powered by Mantis Bugtracker