Kdenlive   bug tracker Home page

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000303KdenliveEffectspublic2008-10-31 21:382009-06-18 23:32
ReporterLeHomard 
Assigned Toddennedy 
PrioritynormalSeverityfeatureReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionRecent git 
Target VersionFixed in Version0.7.3 
Summary0000303: Feature request : Color Balance / Color correction effect
DescriptionThere are many color effect in Kdenlive but there is no color balance or advanced color correction available. The desired result can be obtained with a mix of saturation, hue, contrast, luminosity and gamma, but it it's neither user-friendly nor efficient (for one thing all these settings are in different effects making it very tedious to do color correction on many clips).

One really usefull effect would be Color Balance. For an example see The Gimp Color Balance tool : 3 sliders for colors and a choice between Highlights, Midtones and Shadows (not necessary but useful for advanced tweaking). It is simple to use and understand and at the same time fairly powerful. Using the RGB curves would be even better, but probably not as user-friendly for simple tweaking....

Of course having additional sliders in the same effect for contrast, gamma and saturation would be even better and would make it a lot easier to apply similar color corrections to many clips.
TagsNo tags attached.
Build/Install Method(select)
Attached Files

- Relationships

-  Notes
(0000791)
madsdyd (administrator)
2008-10-31 22:25

Have you tried the frei0r RGB Parade or Vectorscope effects for color corrections? It might not be what you are looking for, but perhaps?

(0000797)
LeHomard (developer)
2008-11-01 15:39

Color correction is possible by combining all the available effect, but it really isn't simple to do, nor to reproduce on several clip. For instance, one of the basic needs would be to compensate bad color balance, or create a specific "mood" for a scene (maybe more green in the midtones in a forest, or pink highlight in a cliché love scene).
A color balance tool would make it really easy, fast and user friendly, instead of playing with lots of different effects to achieve a similar result.
(0000921)
madsdyd (administrator)
2008-11-08 21:52

Acknowledged for version 0.7.1, although it might be later. Perhaps we can convince upstream mlt or frei0r to make a plugin.
(0000922)
madsdyd (administrator)
2008-11-08 21:56

Here is some info on the color balance tool in gimp:
http://www.linuxtopia.org/online_books/graphics_tools/gimp_advanced_guide/gimp_guide_node61_007.html [^]
(0000925)
cinephiliac (updater)
2008-11-08 23:37

To really play the devils advocate...

Premier and aftereffects can use photoshop filters. Rather than hacking together something similar to what's in the Gimp, maybe we (heh, says "he who does not code" ;-) could look at a framework to use Gimp / Krita filters. That way we get more variety, code maintained by other respective projects, a consistent UI across apps and take advantage of any future filters.

Of course I understand this is a bigger job, but maybe for a future version (0.7.2?).
(0000929)
ddennedy (developer)
2008-11-09 01:24

I agree that this needs to be added to MLT. I can base it on my Kino Levels filter and make it keyframe-able if you would please take a look at that.

I already looked into using Gimp plugins in the past, and they do not lend themselves to integration as a library, which is why no one else is doing it. I dunno about Krita. We already use frei0r plugins which are much more generic than Gimp.
(0000933)
madsdyd (administrator)
2008-11-09 01:59

The levels filter from kino would be nice, I think it matches what the reporter wants.

I agree wrt. integration to gimp. Nobody does it, and there is a reason for it. It could be done, just like imageMagick, but it would be way to slow, I think, to be usuable (think couple of frames pr. second).

re. krita integration. I think this is possibly, but again, we do not know about the speed? I found a page for krita plugins here: http://www.krita-plugins.org/ [^]
and some info about the interface here: http://www.koffice.org/krita/Developing%20Krita%20Plugins.html [^]

And, also, basically, mlt will need to be able to host kparts, and this seems kind of weird, that mlt will host kparts, but kdenlive will not :-)
(0001009)
cinephiliac (updater)
2008-11-10 02:21
edited on: 2008-11-10 02:22

Levels (at least in Gimp / Photoshop / Krita, not sure about Kino) is more about adjusting _value_ (brightness). The original post, while mentioning contrast and gamma as *additional* sliders is mainly talking about colour balance which is an adjustment of _Hue_ (which colour).

It sounds to me like LeHomard is after something similar to Gimp's color balance, rather than Gimp's / Kino levels tool.

Is this correct LeHomard?

(0001012)
ddennedy (developer)
2008-11-10 03:38

Yes, there are a lot of different ways to approach color balance and correction. This needs a rather thorough study and design.

Here is the info about Kino's levels tools:
http://kinodv.org/help/fx_levels [^]

Some of this was based upon a digikam plugin.
(0001147)
madsdyd (administrator)
2008-11-12 11:14

Acknowledging as a feature request for 0.7.1 although it may be postponed to a later version.
(0001158)
LeHomard (developer)
2008-11-12 12:48

The levels tool in Kino would be perfect for color correction, at least for me. It has all you need for fairly advanced color correction, including a white balance setting which I hadn't actually thought of but is really a great feature to have !
(0001678)
diffid (reporter)
2008-12-15 14:01

Maybe check this out too:

http://prolost.blogspot.com/2006/12/why-colorista.html [^]
(0001691)
ddennedy (developer)
2008-12-15 19:27

I assigned to me to make sure I add the necessary things to MLT or frei0r to enable something along the lines of Colorista and what Kino does today. This might take a little while. Then, someone else may be take assignment to work on the UI.
(0001692)
madsdyd (administrator)
2008-12-15 19:38

Great Dan!

Please let us know if we can help out in any way.
(0001694)
cinephiliac (updater)
2008-12-15 21:41

Hmmm... If Gimp plugins aren't useful, I wonder about KIPI plugins? They're specifically written for KDE apps, are used in a couple of different applications so they're probably more portable. I suspect that they're not exactly high end, but then, they do have the advantage of being maintained by someone else. :)
(0001696)
ddennedy (developer)
2008-12-15 22:13

If I am to do the work, I will prefer LGPL code that operates in YUV colorspace for the more fundamental features in MLT, and video levels is quite fundamental for me. I am not opposed to KIPI, but I don't know when I will get around to it. Are you aware of a specific KIPI plugin for this problem?
(0001774)
ddennedy (developer)
2008-12-17 23:05

I did a little investigation into KIPI plugins, and these extend the application functionality. They are not really used for image processing. I think Gegl or FreeFrame are contenders for another plugin system. Krita plugins might be possible too.
(0002432)
ddennedy (developer)
2009-02-16 08:29

I made a new frei0r filter called balanc0r based on the White Balance portion of my Kino Levels code. I have yet to post the code for it (real soon now). Meanwhile, the kdenlive support was added in SVN r3055.
(0002435)
ddennedy (developer)
2009-02-17 03:19

My frei0r balanc0r plugin is now published at git://dennedy.org/frei0r.git [^]
I will update this when the main git tree merges it.
(0002553)
madsdyd (administrator)
2009-03-13 23:48

I just tested it today, and it seems to work nice, although I am no expert in how to use these kinds of tools. A very nice addition.

Keeping the issue open, right?
(0002554)
ddennedy (developer)
2009-03-14 03:09

Leave open until the frei0r plugin gets merged into the main, central repo.
(0002679)
ddennedy (developer)
2009-04-09 09:10

This is now in frei0r official git and daily snapshots.

- Issue History
Date Modified Username Field Change
2008-10-31 21:38 LeHomard New Issue
2008-10-31 22:25 madsdyd Note Added: 0000791
2008-10-31 22:25 madsdyd Status new => feedback
2008-11-01 15:39 LeHomard Note Added: 0000797
2008-11-08 21:52 madsdyd Note Added: 0000921
2008-11-08 21:52 madsdyd Status feedback => acknowledged
2008-11-08 21:52 madsdyd Target Version => 0.7.1
2008-11-08 21:56 madsdyd Note Added: 0000922
2008-11-08 23:37 cinephiliac Note Added: 0000925
2008-11-09 01:24 ddennedy Note Added: 0000929
2008-11-09 01:59 madsdyd Note Added: 0000933
2008-11-10 02:21 cinephiliac Note Added: 0001009
2008-11-10 02:22 cinephiliac Note Edited: 0001009
2008-11-10 02:23 cinephiliac Status acknowledged => feedback
2008-11-10 03:38 ddennedy Note Added: 0001012
2008-11-12 11:14 madsdyd Note Added: 0001147
2008-11-12 11:14 madsdyd Status feedback => acknowledged
2008-11-12 12:48 LeHomard Note Added: 0001158
2008-11-17 20:54 madsdyd Target Version 0.7.1 => future version
2008-12-15 14:01 diffid Note Added: 0001678
2008-12-15 19:26 ddennedy Status acknowledged => assigned
2008-12-15 19:26 ddennedy Assigned To => ddennedy
2008-12-15 19:27 ddennedy Note Added: 0001691
2008-12-15 19:38 madsdyd Note Added: 0001692
2008-12-15 21:41 cinephiliac Note Added: 0001694
2008-12-15 22:13 ddennedy Note Added: 0001696
2008-12-17 23:05 ddennedy Note Added: 0001774
2009-02-09 09:35 ddennedy Relationship added has duplicate 0000633
2009-02-09 09:36 ddennedy Relationship deleted has duplicate 0000633
2009-02-16 08:29 ddennedy Note Added: 0002432
2009-02-17 03:19 ddennedy Note Added: 0002435
2009-03-13 23:48 madsdyd Note Added: 0002553
2009-03-14 03:09 ddennedy Note Added: 0002554
2009-04-09 09:10 ddennedy Note Added: 0002679
2009-04-09 09:10 ddennedy Status assigned => resolved
2009-04-09 09:10 ddennedy Resolution open => fixed
2009-06-18 01:56 xzhayon Status resolved => closed
2009-06-18 01:56 xzhayon Fixed in Version => 0.7.3
2009-06-18 23:32 xzhayon Build/Install Method => (select)
2009-06-18 23:32 xzhayon Target Version future version =>


Copyright © 2000 - 2014 MantisBT Team
Powered by Mantis Bugtracker